Robert, pointed out that a check is in place in the trunk.

--rajith

On 1/30/07, Rajith Attapattu <[EMAIL PROTECTED]> wrote:

Hi Folks,

I believe there is some unnecessary message duplication logic in the java
client code, which resolved properly could improve performance in high
volume scenarios.

The sendImpl() in the BasicMessageProducer calls a method called
convertToNativeMessage() which is called every time.
The function of this method is to create an equivalent type of message and
dutifuly copy all the data and headers.
This function is made redundent if the message is created by the same Qpid
provider.
In this instance the orginal message could have been used w/o the
unnecessary creation/copying.

This is only useful if the JMSMessage passed in is in fact created by a
different provider.
This is a very very rare use case.

This method should be invoked selectively.
A check like if originalMsg instanceof
org.apache.qpid.client.message.AMQMessage, then skip
convertToNativeMessage() should be employed.

Regards,

Rajith

Reply via email to