In the notifyMessage(UnprocessedMessage):void method of
BasicMessageConsumer there are still some commented out lines from a
very old commit (merged to trunk over a year ago).
Am I right in assuming there is no real reason for this being commented
out and that it can therefore be deleted?
I would just delete it quietly, but as I don't have the context for the
change that required disabling these lines of code, I thought a quick
mail might be in order (in case they were serving as some sort of
reminder or something?!).
I'm not picking on java, honest! I'm sure there are similar things in
e.g. the c++ code. I'm pointing this case out because it just came up in
conversation. I'd be as happy for people to point out issues they notice
on any code I tend to work on; once noticed its easy to clean up.
The biggest chunk of code in question looks like:
// synchronized (_closed)
{
// if (!_closed.get())
{
//preDeliver(jmsMessage);
notifyMessage(jmsMessage);
}
// else
// {
// _logger.error("MESSAGE REJECTING!");
// _session.rejectMessage(jmsMessage, true);
// //_logger.error("MESSAGE JUST DROPPED!");
// }
but the '// synchronized (_closed)' part is replicated in several places.
