[ 
https://issues.apache.org/jira/browse/QPID-701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aidan Skinner resolved QPID-701.
--------------------------------

    Resolution: Fixed

This has been fixed

> makeBrokerConnection uses a while sleep() and should be updated to use a 
> wait() notify()
> ----------------------------------------------------------------------------------------
>
>                 Key: QPID-701
>                 URL: https://issues.apache.org/jira/browse/QPID-701
>             Project: Qpid
>          Issue Type: Task
>          Components: Java Client
>    Affects Versions: M2.1, M3
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>             Fix For: M3
>
>
> The makeBrokerConnection poses a problem with failover but not on its own. 
> The use of makeBrokerConnection will start the connection process that if it 
> fails will cause the Failover Thread to handle connection. As can be seen in 
> the AMQConnection constructor the majority of the method needs to be moved in 
> to a connect() method as it lets the failover mechanism handle the failover 
> issue. (It does need to be improved as commented in a //todo there is a 
> Thread.sleep loop that could be replaced with a wait() notify() mechanism.)
> The other two cases are related to attempting reconnection due to a 
> redirection which are currently only called as part of the failover mechanism 
> and so should already be wrapped in FailoverSupport

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to