[
https://issues.apache.org/jira/browse/QPID-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617564#action_12617564
]
Ted Ross commented on QPID-1153:
--------------------------------
Two things:
1) Several lines in the patch are oddly truncated. The patch can't be used
without some manual fixups.
2) I claim the logic is still incorrect. For example, if the minimum value
ever goes to zero, the very next value will overwrite the minimum.
-Ted
> managementgen/schema.py initializes unsigned value with -1
> ----------------------------------------------------------
>
> Key: QPID-1153
> URL: https://issues.apache.org/jira/browse/QPID-1153
> Project: Qpid
> Issue Type: Bug
> Components: Code Generator
> Affects Versions: M3
> Environment: Red Hat Enterprise Linux 4, g++ 3.4.6
> Reporter: Steve Huston
> Assignee: Ted Ross
> Priority: Minor
> Attachments: schema.py.diff
>
>
> The cpp/managementgen/schema.py script generates
> gen/qpid/management/Queue.cpp that causes compile warnings which are promoted
> to errors by the build settings. The warnings are:
> gen/qpid/management/Queue.cpp: In constructor
> `qpid::management::Queue::Queue(qpid::management::Manageable*,
> qpid::management::Manageable*, std::string, uint8_t, uint8_t, uint8_t)':
> gen/qpid/management/Queue.cpp:80: warning: converting of negative value
> `-0x000000001' to `uint64_t'
> gen/qpid/management/Queue.cpp: In member function `virtual void
> qpid::management::Queue::writeStatistics(qpid::framing::Buffer&, bool)':
> gen/qpid/management/Queue.cpp:527: warning: converting of negative value
> `-0x000000001' to `uint64_t'
> The attached patch resolves the warnings by initializing using the value set
> in the spec. At this time, that turns out to be 0.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
