Add VirtualHostFactory and VirtualHostRegistry.getDefaultVirtualHost()
----------------------------------------------------------------------

                 Key: QPID-1271
                 URL: https://issues.apache.org/jira/browse/QPID-1271
             Project: Qpid
          Issue Type: Improvement
          Components: Java Broker
    Affects Versions: M3
            Reporter: Martin Ritchie
             Fix For: M4


Summary:

Currently our testing is quite fragile. Either tests rely on their being a 
"test" virtualhost or they they create a new VirtualHost.

The first litters our tests with literal values and would require a large 
update if the "test" vhost was removed.

The second approach leaves the VirtualHost unregisterd to any 
ApplicationRegistry and so is not correctly cleaned up by the 
ApplicationRegistry.remove()

The addition of a VirtualHostFactory will improve the stability of our testing 
by ensuring the registration takes place for the instances where a new 
VirtualHost is required. The addition of the getDefaultVirtualHost() method to 
the VirtulalHostRegistry would allow the removal of the literal "test" in our 
current tests.

The VirtualHostRegistry currently has a setDefaultVirtualHost but does not have 
a method to retrieve this value which could be used in place of the 
getVirtualHost("test") that our tests mainly use.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to