[ 
https://issues.apache.org/jira/browse/QPID-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637930#action_12637930
 ] 

Rob Godfrey commented on QPID-1319:
-----------------------------------

Comment on the following snippet:

269              if (_options.containsKey(ConnectionURL.OPTIONS_SSL))
270                      {
271                          try
272                          {
273                              return 
Boolean.parseBoolean(_options.get(ConnectionURL.OPTIONS_SSL));
274                          }
275                          catch (NumberFormatException nfe)
276                          {
277                              //Do nothing as we will use the default below.
278                          }

AFAICT there is no way that Boolean.parseBoolean can throw a NFE...  

Looking at the publically available Sun 1.6 source code parseBoolean can never 
throw an exceptions directly...



> Options for a broker (given in the broker list in the connection URL) should 
> default to the top level values
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-1319
>                 URL: https://issues.apache.org/jira/browse/QPID-1319
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: M4
>            Reporter: Rajith Attapattu
>            Assignee: Rajith Attapattu
>             Fix For: M4
>
>
> Options for a given broker (specified in the broker list in conneciton URL) 
> should default  to the top level values unless specified explictly.
> However there seems to be only one such option, which is SSL. (according to 
> the wiki)
> Ih the future there maybe more such options.
> Currently if SSL option is specified in top level options, it doesn't get 
> copied to individual broker level options.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to