On Tue, 2008-10-28 at 14:35 +0000, Gordon Sim wrote: > Alan Conway wrote: > > Apologies for doing this right at the code freeze but I only realized 2 > > days ago that the AckPolicy API was broken. The new API is only > > incompatible for code that uses AckPolicy, it provides full flexibility > > for manual or automatic control over acquire and accept of subscribed > > messages. It also makes Subscription a first-class object which provides > > a single logical place to collect future changes to subscriptions. > > I like the changes; a big improvement! A couple of points however: > > * In moving from AckPolicy the automatic sending of completion status > has been lost. That is needed for window mode. (A message should only be > marked completed when processed in my view, i.e. after and not before > the listeners received call returns). > > * I'm not sure that it makes sense to conflate acquire with acking on > autoAck. (If we need it, I think a separate autoAcquire setting would be > better). > > * When acquiring a message you have to test the results before you can > be sure that the message was actually acquired. > > Attached is a patch that addresses these points. Thoughts?
Looks good to me.
