[
https://issues.apache.org/jira/browse/QPID-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Huston resolved QPID-1435.
--------------------------------
Resolution: Fixed
Committed in svn revision 711603
> TxOp.h compile warning TxOpConstVisitor
> ---------------------------------------
>
> Key: QPID-1435
> URL: https://issues.apache.org/jira/browse/QPID-1435
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker
> Affects Versions: M4
> Environment: Windows
> Reporter: Steve Huston
> Assignee: Steve Huston
>
> Recent change to TxOp.h and new TxOpVisitor.h cause the following compile
> warning on Visual Studio:
> c:\ace\exported\qpid\trunk\qpid\cpp\src\qpid\broker\TxOp.h(31) : warning
> C4099: 'qpid::broker::TxOpConstVisitor' : type name first seen using 'struct'
> now seen using 'class'
> c:\ace\exported\qpid\trunk\qpid\cpp\src\qpid\broker\TxOpVisitor.h(39)
> : see declaration of 'qpid::broker::TxOpConstVisitor'
> Since TxOp.h already includes TxOpVisitor.h, there's no need to re-declare
> TxOpConstVisitor further down. Removing that fixes this. In the event it
> sometime becomes better to declare it rather than including TxOpVisitor.h, it
> should be declare using "struct" since that what it's defined as in
> TxOpVisitor.h
> Index: TxOp.h
> ===================================================================
> --- TxOp.h (revision 711592)
> +++ TxOp.h (working copy)
> @@ -28,8 +28,6 @@
> namespace qpid {
> namespace broker {
> -class TxOpConstVisitor;
> -
> class TxOp{
> public:
> typedef boost::shared_ptr<TxOp> shared_ptr;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
