2008/11/19 Cliff Jansen (Interop Systems Inc) <[EMAIL PROTECTED]>: > Greetings qpid-dev, > > I work with Anandeep at Microsoft and have started looking at some of > the C++ related Jiras. > > The build error in QPID-1424 results from the debug implementation of > lower_bound() in VC++, which is fussy in nature, and insists that the > comp() function meet the exact definition of a "strict weak ordering". > In particular, it requires that the first and second arguments have > the same type while it tries to "helpfully" perform a sanity check. > When not building a debug version, the check is omitted and the code > compiles just fine. > > I have attached a patch that avoids the use of std::lower_bound() and > uses a simpler but slower linear search when compiling on Windows in > debug mode. That seems to be the easiest way to solve the problem > without intrusive code changes after the M4 code freeze. > > The patch is attached. Let me know if it requires reworking in any > way. > > Thanks. > > Cliff
Hi Cliff, Welcome and thank you for the patch, it is always good to see new people coming to the project. I just wanted to take this opportunity to remind everyone that any submission from a non-committer needs to be added to a JIRA and rights granted to the ASF for inclusion in the project. Regards Martin -- Martin Ritchie
