[ 
https://issues.apache.org/jira/browse/QPID-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650177#action_12650177
 ] 

Rob Godfrey commented on QPID-1251:
-----------------------------------

other than having the { on the same line as try; I think the code is fine.

It should be safe to swallow version negotiation exceptions here.

Would obviously like to see some (unit) tests that expose the issue if poss 

> IO transport does not cleanly close on Windows
> ----------------------------------------------
>
>                 Key: QPID-1251
>                 URL: https://issues.apache.org/jira/browse/QPID-1251
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: M3
>         Environment: Windows
>            Reporter: Arnaud Simon
>            Assignee: Rob Godfrey
>            Priority: Blocker
>             Fix For: M4
>
>         Attachments: QPID-1251.patch
>
>
> Description: 
> There is an issue on Windows platform with the io transport as 
> socket.shutdownInput() does not result of the reader getting an EOF. This 
> means that the IOReceiver thread does not terminate as expected and the main 
> thread does not join. This prevents the protocol version switching mechanism 
> to work.  
> Solution:
> We will be using a new nio transport that should solve this issue. I would 
> therefore suggest that we only provide a simple mechanism for selecting the 
> default version used and tell Windows users to set it to 0.9 when using the 
> current java broker. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to