Doesn't this break the if...then... else logic? I didn't/can't test this
because we don't use send on POP but shouldn't this be:
if ( buffer[0] == '.' ) {
/*
* Exit on end of message
*/
if ( buffer[1] == '\0' ) {
DEBUG_LOG0 ( p, "Received end of msg" );
fclose ( tmp );
p->xmitting = FALSE;
Pop ( &(p->InProcess) );
pop_xmit_exec ( p );
}
/*
* sendmail will not remove escaped ..
*/
else {
if ( buffer[1] == '.' )
fputs ( &buffer[1], tmp );
else {
fputs ( buffer, tmp );
fputc ( '\n', tmp );
} else {
fputs ( buffer, tmp );
fputc ( '\n', tmp );
}
return 0;
}
At 11:15 PM 4/25/2001 -0700, Jacques Distler wrote:
>-----BEGIN PGP SIGNED MESSAGE-----
>
>"Roy C. Bixler" <[EMAIL PROTECTED]> wrote:
>
>I tried to upgrade from qpopper 3.12 to 4.0 on a Linux server, but found
>that I had to revert when I got complaints from users of Eudora 3.0 who
>use send on POP feature. Their messages were not going out as usual
>because the headers of their sent messages suddenly appeared all on one
>line. I plan to have those users upgrade to a later Eudora version and
>use authenticated SMTP instead, but wonder if the apparent send on POP
>breakage is a known issue.
>
>I see the following comment in popper/pop_xmit.c:
>
> * 06/11/00 [rg]
> * - Applied patch by Clifton Royston to translate network EOL
> * (CRLF) to local EOL ('\n').
> * - Now only initial ".\n' is recognized as end-of-msg (instead
> * of any line which starts with a "." and ends with a ".").
>
>Could that have anything to do with the problem?
>
>
>Sorta.
>
>XTND XMIT is, indeed (still) broken (as of 4.0.1). The buffer is written to
>the temp file with no '\n' to terminate the line(s) (Doh!).
>
>The following patch fixes it:
>
>*** popper/pop_xmit.c.orig Tue Feb 20 19:15:21 2001
>- --- popper/pop_xmit.c Thu Apr 26 00:43:34 2001
>***************
>*** 165,172 ****
>- --- 166,175 ----
> fputs ( &buffer[1], tmp );
> else
> fputs ( buffer, tmp );
>+ fputc ( '\n', tmp );
> } else
> fputs ( buffer, tmp );
>+ fputc ( '\n', tmp );
> return 0;
> }
>
>Jacques
>
>-----BEGIN PGP SIGNATURE-----
>Version: PGP
>Comment: Public Key - http://golem.ph.utexas.edu/~distler/distler.asc
>
>iQCVAwUBOue9EaIBi34rsX+ZAQGC3QP+Jb5eWn90zp4hNU4jDpYvLYVi2c4fEDc1
>EACjC6iQbdbEGgstLjQvtbIDfZtRM7SxNg5Sut3bkbe8GDuI/sFeI+YzAFHdeSOM
>YA/54n1fcaABuRGanMIMBVVEWvKzP6RZCCphsFmJwk030JmI8gwD5LHi8i6ZmC2a
>6RNPEPA/aSw=
>=U9aO
>-----END PGP SIGNATURE-----
--------------------------------------------------------------------------------------------------
New software available at http://www.telicsolutions.net/soft
If you have ICQ you can message me at ICQ#:9736582
Eric Krichbaum, MCSE, MCP+IS, ASE, CCNA, A+, CNA, developer
--------------------------------------------------------------------------------------------------
