Diego d'Ambra wrote:
Matt Sergeant wrote:
[...]
Some of these may have been solved in other places, but I would be
willing to test and check if they are still needed and patch against
latest revision.
Any interest?
Yes of course.
Great - sorry for the slow reply.
During move to vanilla qpsmtpd-prefork I stumbled over 1 minor issue.
Daemon fails to start if using argument --interface, due to tainted data
in $d_addr.
Suggested patch attached, note I've little experience with IPv6 and
module Data::Validate::IP doesn't yet support it, so others may want to
add IPv6 validation.
For what it's worth, the "taint checking of config files" got hashed over a
while ago:
http://www.nntp.perl.org/group/perl.qpsmtpd/2005/04/msg2815.html
I think the end result was that it should be safe to trust the config.
Elliot
P.S. Thank you for cleaning up -prefork. I will likely be taking advantage of
your work soon (migrating away from -forkserver)
