On Jan 18, 2010, at 8:32, Peter J. Holzer wrote: > In mid-November I found a bug in Qpsmtpd::config. I created issue 29 on > Google Code (http://code.google.com/p/smtpd/issues/detail?id=29) and > some time later checked a fix into my github repository and
Hi Peter! You did the right thing; except it's better to send patches to the list than pull requests. (So have it in github, but also send the patches to the list for review). It's basically just: git format-patch HEAD^.. # or HEAD~5..HEAD~3 or whatever you need to specify the patch series git send-email 000* I think my concern with your change was if it was the right thing to do for configuration plugins (as you noted in a comment in your code, too). - ask -- http://develooper.com/ - http://askask.com/
