On May 6, 2012, at 3:55 PM, Robert Spier wrote: > I think I like the concept, I'm concerned about backwards compatibility with > people who have written log parsers. I was going to just apply it, but ... > it doesn't apply cleanly to the head of the tree, so I'm going to skip it for > now. Please re-sync and add an entry to Changes.
Like dlog? Which is currently broken anyway (at least for my attempts to use it)? Which others parsers for qpsmtpd logs exist? I'll look at them, and attempt to offer patches to their authors. I expect the parser authors will forgive me for changing the format. When I'm done with logging changes, they'll have a consistent log format that EVERY built-in plugin uses, and even a "built-in" implementation to reference. This patch is a huge win for humans that are reading the log files, and it also makes parsing them easier as well. Matt > On Sun, May 6, 2012 at 11:27 AM, Matt Simerson <m...@tnpi.net> wrote: > in log entries, print hook name first, so log entries look like this: > > 86553 (connect) ident::geoip: US, United States > 86553 (connect) ident::p0f: Windows 7 or 8 > 86553 (connect) check_earlytalker: remote host said nothing spontaneous, > proceeding > > instead of this: > > 86553 ident::geoip: (connect): US, United States > 86553 ident::p0f: (connect) Windows 7 or 8 > 86553 check_earlytalker: (connect): remote host said nothing spontaneous, > proceeding > ---
