Re: Issues in the current HEAD

[Hans Salvisberg]

No, I don't think this has made any difference.

 

This is the error output written for an outgoing mail, i.e. submitted by an authorized user, after applying the patch:

 

...

4358 4358 click, disconnecting

4358 4358 (post-connection) connection_time: 1.528 s.

 

4358 FATAL PLUGIN ERROR [logging::file_3a0]: Can't call method "hook_logging" on unblessed reference at lib/Qpsmtpd/Plugin.pm line 47 during global destruction.

FATAL PLUGIN ERROR [logging::file_3a0]: Can't call method "hook_logging" on unblessed reference at lib/Qpsmtpd/Plugin.pm line 47 during global destruction.
FATAL PLUGIN ERROR [logging::file_3a1]: Can't call method "hook_logging" on unblessed reference at lib/Qpsmtpd/Plugin.pm line 47 during global destruction.
FATAL PLUGIN ERROR [logging::file_3a2]: Can't call method "hook_logging" on unblessed reference at lib/Qpsmtpd/Plugin.pm line 47 during global destruction.
FATAL PLUGIN ERROR [logging::file_3a3]: Can't call method "hook_logging" on unblessed reference at lib/Qpsmtpd/Plugin.pm line 47 during global destruction.
FATAL PLUGIN ERROR [logging::file_3a7]: Can't call method "hook_logging" on unblessed reference at lib/Qpsmtpd/Plugin.pm line 47 during global destruction.

 

If we call the block above

0  0 1 2 3 7

then it's followed by

1  0 1 2 3 7

2  0 1 2 3 7

3  0 1 2 3 7

7  0 1 2 3 7

and finally

 

Can't call method "warn_handler" on an undefined value at /home/smtpd/qpsmtpd/qpsmtpd line 21 during global destruction.

 

 

Gesendet: Sonntag, 04. Januar 2015 um 07:46 Uhr
Von: "Jared Johnson" <jjohn...@efolder.net>
An: "salvi...@gmx.ch" <salvi...@gmx.ch>
Cc: "qpsmtpd@perl.org" <qpsmtpd@perl.org>
Betreff: Re: Issues in the current HEAD

I'm about 51% sure that this will fix it, but I can't arrange a quick test just now because apparently xinetd is gone from os x mavericks.  If you feel like testing this I would be interested in your results:

 

index 3675829..141214c 100755

--- a/qpsmtpd

+++ b/qpsmtpd

@@ -17,8 +17,8 @@ delete $ENV{ENV};

 $ENV{PATH} = '/bin:/usr/bin:/var/qmail/bin';

 

 my $qpsmtpd = Qpsmtpd::TcpServer->new();

-$SIG{__WARN__} = sub { $qpsmtpd->warn_handler(@_) };

 $qpsmtpd->load_plugins();

+$SIG{__WARN__} = sub { $qpsmtpd->warn_handler(@_) };

 $qpsmtpd->start_connection();

 $qpsmtpd->run(\*STDIN);    # pass the "socket" like -prefork/-forkserver

 $qpsmtpd->run_hooks("post-connection");

 

Master has #168 reverted so that will probably work for you now as well, but if the above change works I can re-submit this PR in a working state.

 

-Jared

 

---

From: Jared Johnson <jjohn...@efolder.net>
Sent: Saturday, January 3, 2015 11:11 PM
To: salvi...@gmx.ch
Cc: qpsmtpd@perl.org
Subject: Re: Issues in the current HEAD

 

Regarding the warn_handler message, I probably managed to mess up my recently merged https://github.com/smtpd/qpsmtpd/pull/168 for xinetd mode. Unfortunately my availability will be spotty this week. As a temporary fix, you could use a different mode (I recorded prefork) or un-merge that PR. Of course this may be the least of your problems.

On Jan 3, 2015 5:12 PM, salvi...@gmx.ch wrote:

I'm using xinetd according to http://wiki.qpsmtpd.org/doku.php?id=deploy:start, i.e. no daemon mode but just running

exec qpsmtpd


-----Ursprüngliche Nachricht-----
Gesendet: Saturday, 03 January 2015 um 23:31:06 Uhr
Von: "Jared Johnson" <jjohn...@efolder.net>
An: "salvi...@gmx.ch" <salvi...@gmx.ch>
Betreff: Re: Issues in the current HEAD

What daemon mode are you using? Prefork?
--
*** DoubleCheck identified this as CLEAN. Give feedback:
*** This is SPAM: http://filter.emailportal.com
*** More options: http://filter.emailportal.com