> ________________________________________ > From: [email protected] > [[email protected]] on behalf of ext > Theo de Vries [[email protected]] > Sent: Thursday, August 30, 2012 10:37 > To: Konstantin Tokarev > Cc: [email protected]; [email protected] > Subject: Re: [Qt-creator] Why Creator's Qbs plugin need to special process > for Qt? > > 2012/8/29 Konstantin Tokarev <[email protected]>: > > > > 29.08.2012, 07:55, "Loaden" <[email protected]>: > >> See: > >> void QbsProject::createBuildProject(const QString &buildProjectName, > >> QtSupport::BaseQtVersion *qtVersion) > >> { > >> if (qtVersion) { > >> if (qtVersion->defaultBuildConfig() == > >> QtSupport::BaseQtVersion::DebugBuild || qtVersion->defaultBuildConfig() == > >> QtSupport::BaseQtVersion::BuildAll) { > >> buildConfiguration["qbs.buildVariant"] = "debug"; > >> } else { > >> buildConfiguration["qbs.buildVariant"] = "release"; > >> } > >> buildConfiguration["qt/core.qtPath"] = > >> qtVersion->sourcePath().toString(); > >> > >> } else { > >> buildConfiguration["qbs.buildVariant"] = "debug"; > >> } > >> > >> I don't like the design. > >> I thought QbsProjectManager should like CMakeProjectManager. > >> No need Qt depends! > > > > Actually, missing Qt dependence is a big gap in CMakeProjectManager which > > needs to be fixed. > > > > -- > > Regards, > > Konstantin > > _______________________________________________ > > Qt-creator mailing list > > [email protected] > > http://lists.qt-project.org/mailman/listinfo/qt-creator > > Konstantin, would you mind explaining your point of view? I can see > that Qt dependence is an advantage when building a Qt project, but > when doing a non-Qt development, I agree with Loaden that it is a pain > to have a dependency on qtVersion etc as in the current design of qbs.
The plugin + code should have a dependency on Qt support, to give the user best support for it. But that doesn't mean that the code should depend on a Qt version being even configured. I.e. projects that don't use Qt shouldn't need Qt configured, projects that use Qt should get best support for it. -- Eike Ziller Principal Software Engineer Nokia, Qt Development Frameworks Nokia gate5 GmbH Firmensitz: Invalidenstr. 117, 10115 Berlin, Germany Registergericht: Amtsgericht Charlottenburg, Berlin: HRB 106443 B Umsatzsteueridentifikationsnummer: DE 812 845 193 Geschäftsführer: Dr. Michael Halbherr, Karim Tähtivuori _______________________________________________ Qt-creator mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/qt-creator
