Yes, I was talking about the plugin as the thread was about that. :-) Thanks, you just reminded me I haven't posted here yet... ;-)
On Wed, Dec 18, 2019 at 7:07 PM Francesc Martinez <[email protected]> wrote: > Thanks for the input! I don't know why I was thinking on the code in the > GitQlient. I guess that I still see the plugin as a wrapper, but I will > definitely have to fix it. > > By the way, nice entry in your blog about the plugins. I'll take a look > deeply. > > Francesc. > > El mié., 18 dic. 2019 17:57, Davide Coppola <[email protected]> > escribió: > >> Sure, here some for GitQlientPlugin in random order: >> >> - Includes have no order >> - Many includes can be removed >> - Empty functions and default comments can be deleted >> - MyMode is not a very descriptive name for a class >> - MyMode code could be placed in a separated .h/.cpp files >> - You're using #ifndef/#define/#endif guards instead of #pragma once >> (like in GitQlient) >> - You can get rid of GitQlientPluginConstants.h >> and GitQlientPlugin_global.h >> >> Cheers >> >> On Wed, Dec 18, 2019 at 5:07 PM Francesc Martinez <[email protected]> >> wrote: >> >>> Hi! >>> >>> Thanks for your feedback! >>> >>> Could you give some thoughts on what would you polish and what you find >>> messy? >>> >>> I still have re-ordering to do after the big refactor, but having other >>> people's opinion is really appreciated. >>> >>> Best, >>> Francesc. >>> >>> El mié., 18 dic. 2019 17:02, Davide Coppola <[email protected]> >>> escribió: >>> >>>> Hi Francesc, >>>> >>>> First of all, congrats on the release and kudos for providing binaries >>>> for all architectures! >>>> >>>> I didn't have time to try it yet, but after a quick look at the project >>>> on GitHub I would recommend you to polish your code a bit before going >>>> forward with this project. Things look pretty messy already and if you keep >>>> adding more new stuff it will get harder. >>>> >>>> All the best >>>> >>>> >>>> On Mon, Dec 16, 2019 at 10:02 AM Francesc Martinez < >>>> [email protected]> wrote: >>>> >>>>> Hi all, >>>>> >>>>> Today I've announced in the Planet that I've released a plugin to >>>>> integrate Git in QtCreator. I know that a long while ago there was someone >>>>> asking to integrate one of the Qt Git apps into the IDE and I'm confident >>>>> to said that this is done. And with GPLv2 license, of course! >>>>> >>>>> I've you have not seen the post in the planet you can find it here: >>>>> https://www.francescmm.com/new-git-plugin-for-qtcreator/ >>>>> >>>>> In addition, you can download the plugin directly from GitHub: >>>>> https://github.com/francescmm/GitQlientPlugin/releases/tag/v1.0.0 >>>>> >>>>> I've compiled and tested it in Windows and Linux (main OS). >>>>> >>>>> I'll be happy if you can provide feedback about improvements, fixes, >>>>> etc. >>>>> >>>>> I hope you don't see this as pure spam since I just want to give back >>>>> something to the Qt community after all this years of learning. >>>>> >>>>> Francesc. >>>>> _______________________________________________ >>>>> Qt-creator mailing list >>>>> [email protected] >>>>> https://lists.qt-project.org/listinfo/qt-creator >>>>> >>>> >>>> >>>> -- >>>> *Davide Coppola* >>>> >>>> *website:* http://www.davidecoppola.com >>>> *blog:* http://blog.davidecoppola.com >>>> >>>> [image: Follow Us on Github] <https://github.com/vivaladav> >>>> <http://www.linkedin.com/in/davidecoppola> >>>> <http://www.twitter.com/vivaladav> >>>> >>> >> >> -- >> *Davide Coppola* >> >> *website:* http://www.davidecoppola.com >> *blog:* http://blog.davidecoppola.com >> >> [image: Follow Us on Github] <https://github.com/vivaladav> >> <http://www.linkedin.com/in/davidecoppola> >> <http://www.twitter.com/vivaladav> >> > -- *Davide Coppola* *website:* http://www.davidecoppola.com *blog:* http://blog.davidecoppola.com [image: Follow Us on Github] <https://github.com/vivaladav> <http://www.linkedin.com/in/davidecoppola> <http://www.twitter.com/vivaladav>
_______________________________________________ Qt-creator mailing list [email protected] https://lists.qt-project.org/listinfo/qt-creator
