Hello again,
the answer to most of your questions is that the patch provided is just
ported to the latest git from the original version [1] and that's how it
was made initially
On 2015-06-15 19:58, Donald Sharp wrote:
Possibly need to break up the patch into smaller patches, starting
with changes to lib, then zebra, then bgp.
Why does bgp display the realm id, not the the realm name?
Perhaps a number is shorter from free text name and takes less space.
Also we will not need to reread it's value based on the stored value in
the structure.
Why is support for realms bgp only? Shouldn't it just be part of the
normal route-map code in lib/routemap.c?( I may be wrong here, I can
safely say I don't fully understand the routemap code yet )
I am afraid with my limited C skills it will take a long time to do it
that way, but other protocols could benefit from realms too, yes.
Is there any particular reason we reread /etc/iproute2/rt_realms file
for every call into rtnl_rtrealm_a2n()?
So we can add/change the realms list without restart ... probably a
short time cache can be implemented later
The expected file format for /etc/iproute2/rt_realms is pretty
limiting, is this intentional?( Who maintains this file? By hand? )
The file is part of iproute2 and is maintained manually, but iproute2
does not export it's functions in a lib, so the only choice is to borrow
the code from rt_names.[ch]
I think I would prefer to just add the u_int16_t realmid to
rib_add_ipv4 function and ignore the realmid passed in if it's not
used. I'm not a big fan of functions with different #'s of parameters
based upon configure options. I would personally prefer the lower
level function just do the 'right' thing if it's configured and do the
right thing if it's not.
If this is the preferred way - I can rewrite the patch that way
donald
On 6/15/15 10:24 AM, Kaloyan Kovachev wrote:
Hello devs,
I am using the realms patch from Adrian Ban [1] for several years, but
it is still missing from Quagga, while it is very useful (not only for
me I hope).
I have ported the patch for the latest version on GitHup and while
working on it found another small bug, which I have fixed [3]
Is there something else that needs to be done so they can be included
in the official source?
[1] http://linux.mantech.ro/quagga+realm_en.php
[2]
https://github.com/KaloNK/quagga/commit/9e9a79c5d11863c271477262d2dc2e94b94fdcd2
[3]
https://github.com/KaloNK/quagga/commit/1037020f7708c599ce9c9c8b2e36463e532aaa98
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
