no... We should isolate the #ifdef code into rt_names.c and rt_names.h. donald
On Fri, Sep 25, 2015 at 9:30 AM, Kaloyan Kovachev <[email protected]> wrote: > Yes, > that's exactly the case - see > https://github.com/KaloNK/quagga/blob/realms_patchset/zebra/zebra_vty.c > > > On 2015-09-25 16:27, Donald Sharp wrote: > > You call rtnl_rtrealm_a2n from zebra_vty.c. zebra_vty.c is built and used >> on every platform. You need to provide non realms versions of these calls >> so that when people call rtnl_realm_a2n they are provided with a realmid >> that is useful. >> >> In this case I would have something like this in rt_names.c: >> >> #ifdef SUPPORT_REALMS >> <your original code> >> #else >> <code to silently do nothing as if no realms were configured at all> >> #endif >> >> On Fri, Sep 25, 2015 at 9:20 AM, Kaloyan Kovachev <[email protected]> >> wrote: >> Hello, >> both calls are inside ifdef checking for SUPPORT_REALMS, which in turn is >> only possible if opsys is gnu-linux. I don't understand how it can be >> enabled at all?! Is the patch changed? >> >> On 2015-09-25 16:08, Donald Sharp wrote: >> >> Kaloyan - >> The Freebsd and Netbsd build failures are a result of the realms patches. >> Can you please submit a patch that fixes these issues? I believe these >> build failures fall under the original CR comment I had where I wanted an >> abstraction such that platforms without the idea of realms would return a >> safe it works value so the code flow can be the same. >> >> thanks! >> >> donald >> >> On Fri, Sep 25, 2015 at 6:03 AM, Martin Winter < >> [email protected]> wrote: >> >> I've added the branch to git CI system (manual at this time, but was >> planning to get this >> automated in future) >> >> https://ci1.netdef.org/browse/QUAGGA-QMASTER [1] [1] and then select the >> branch next to title. >> You should see the "volatile-patch-tracking-3-proposed-ft" branch there. >> >> Whenever a new commit is pushed, it should get kicked off automatically. >> (But with some delay >> as our git mirror only syncs up to savannah every hour). >> >> At this time (commit 6d4daab) it fails to compile on FreeBSD, CentOS & >> NetBSD and works on Ubuntu and Debian >> >> Current Issues: >> >> FreeBSD 10: (see >> https://ci1.netdef.org/browse/QUAGGA-QMASTER1-CI003BUILD-1 [2] [2] ) >> kernel_socket.c:966:66: error: too few arguments to function call, >> expected 12, have 11 >> NULL, 0, VRF_DEFAULT, 0, 0, 0, SAFI_UNICAST); >> ^ >> ./rib.h:506:1: note: 'rib_add_ipv4' declared here >> extern int rib_add_ipv4 (int type, int flags, struct prefix_ipv4 *p, >> ^ >> 1 error generated. >> >> FreeBSD 8 & (see >> https://ci1.netdef.org/browse/QUAGGA-QMASTER1-CI009BUILD-1 [3] [3] ) >> FreeBSD 9: (see >> https://ci1.netdef.org/browse/QUAGGA-QMASTER1-CI004BUILD-1 [4] [4] ) >> zebra_vty.o: In function `static_ipv6_func': >> /usr/home/ci/cibuild.1/quagga-source/zebra/zebra_vty.c:2602: undefined >> reference to `rtnl_rtrealm_a2n' >> zebra_vty.o: In function `zebra_static_ipv4_safi': >> /usr/home/ci/cibuild.1/quagga-source/zebra/zebra_vty.c:63: undefined >> reference to `rtnl_rtrealm_a2n' >> >> CentOS 7: (see https://ci1.netdef.org/browse/QUAGGA-QMASTER1-CI005BUILD-1 >> [5] [5] ) >> Compiles, but fails on rpm generation. This is my issue as I'm using my >> own spec and need to update >> it based on the now included pimd start files. Will fix tomorrow… >> >> CentOS 6: (see https://ci1.netdef.org/browse/QUAGGA-QMASTER1-CI006BUILD-1 >> [6] [6] ) >> cc1: error: unrecognized command line option "-Wno-unused-result" >> (mentioned earlier and I there is already a proposed fix by Donald under >> Patchwork ID 1357) >> >> NetBSD 7: (see https://ci1.netdef.org/browse/QUAGGA-QMASTER1-CI007BUILD-1 >> [7] [7] ) >> kernel_socket.c: In function 'rtm_read': >> kernel_socket.c:966:23: error: too few arguments to function >> 'rib_add_ipv4' >> rib.h:506:12: note: declared here >> >> Regards, >> Martin Winter >> [email protected] >> >> _______________________________________________ >> Quagga-dev mailing list >> [email protected] >> https://lists.quagga.net/mailman/listinfo/quagga-dev [8] [8] >> >> Links: >> ------ >> [1] https://ci1.netdef.org/browse/QUAGGA-QMASTER [1] >> [2] https://ci1.netdef.org/browse/QUAGGA-QMASTER1-CI003BUILD-1 [2] >> [3] https://ci1.netdef.org/browse/QUAGGA-QMASTER1-CI009BUILD-1 [3] >> [4] https://ci1.netdef.org/browse/QUAGGA-QMASTER1-CI004BUILD-1 [4] >> [5] https://ci1.netdef.org/browse/QUAGGA-QMASTER1-CI005BUILD-1 [5] >> [6] https://ci1.netdef.org/browse/QUAGGA-QMASTER1-CI006BUILD-1 [6] >> [7] https://ci1.netdef.org/browse/QUAGGA-QMASTER1-CI007BUILD-1 [7] >> [8] https://lists.quagga.net/mailman/listinfo/quagga-dev [8] >> > > > > Links: > ------ > [1] https://ci1.netdef.org/browse/QUAGGA-QMASTER > [2] https://ci1.netdef.org/browse/QUAGGA-QMASTER1-CI003BUILD-1 > [3] https://ci1.netdef.org/browse/QUAGGA-QMASTER1-CI009BUILD-1 > [4] https://ci1.netdef.org/browse/QUAGGA-QMASTER1-CI004BUILD-1 > [5] https://ci1.netdef.org/browse/QUAGGA-QMASTER1-CI005BUILD-1 > [6] https://ci1.netdef.org/browse/QUAGGA-QMASTER1-CI006BUILD-1 > [7] https://ci1.netdef.org/browse/QUAGGA-QMASTER1-CI007BUILD-1 > [8] https://lists.quagga.net/mailman/listinfo/quagga-dev >
_______________________________________________ Quagga-dev mailing list [email protected] https://lists.quagga.net/mailman/listinfo/quagga-dev
