I'm confused Joakim, I thought your last code review comment was just fix the path->unnumbered test that was in there. I need to test that change internally before I can reflect it back out.
How is path->unnumbered a hack? donald On Thu, Dec 3, 2015 at 11:32 AM, Joakim Tjernlund < [email protected]> wrote: > On Thu, 2015-12-03 at 11:14 -0500, Donald Sharp wrote: > > This is the 3rd version of Cumulus Code Changes. This includes CR > comments > > from take-2( apologies if I have missed anything ) as well as the > addition > > of another 40 or so patches from our internal tree. > > > > I'm posting the cover-letter first to get input from the rest of the > community > > on how they would like to see these patches posted to the list. I do > not want > > this to get lost in the shuffle and if I receive no comments in the next > couple > > of days I will git send-email the whole thing :) > > > > For those impatient here is the github branch these changes are on: > > https://github.com/donaldsharp/quagga/tree/take-3 > > > > Ayan Banerjee (6): > > Quagga: ipv6 multipath support > > Enable support for BGP IPV6 multipath. > > Send ARP requests proactively during OSPF Adjacency formation. > > OSPF: Ensure deletion is clean > > OSPF: Ensure that OSPF can send out multiple packets per thread > > OSPF: Limit the number of interfaces serviced at one time > > > > Daniel Walton (31): > > The peer-groups parser is missing advertisement-interval and 'timers > > connect' > > BGP doesn't count a route with an unreachable nexthop in PfxRcd > > bgpd: Improve peer scaling > > Fix "no set metric" for ospf6 and RIP > > Make "no redistribute" always remove the redistribute statement > > iBGP multipath is broken if 'bgp deterministic-med' is enabled. > > Fix aggregation issues found via ANVL > > Add clear command to force a bestpath recalculation and > > re-advertisement of a prefix > > BGP crashes if attributes alone consume > 4096 bytes > > Add [bestpath|multipath] option to 'show ip bgp x.x.x.x' > > OSPFv3 should accept long form of "no redistribute" > > BGP: Display BGP paths with unreachable nexthps as invalid > > OSPF: Fix no ip ospf hello-interval > > OSPF: "show ip ospf neighbor" header spacing > > BGP: flag paths for multipath if we RX link-local and global nexthops > > Zebra: Add internal support for route tags > > Zebra: Add ability to read/write tag value > > BGP: Add support for route tags > > RIP: add support for route tags > > ZEBRA: add support for route tags > > bgpd: atomic-aggregate is lost when we aggregate another aggregate > > that has atomic-aggregate > > 'set metric -12' is broken in the parser > > bgp: Alow gracefull shutdown of peers > > bgpd: Add replace-as option to remove-private-as > > BGP: Clarify the different permutations of soft clearing a peer > > BGP: Overhaul BGP debugs > > BGP: Implement BGP as-override feature > > BGP: Fix BGP_INFO_ATTR_CHANGED being cleared incorrectly > > BGP: Correct a few fuzz failures in BGP > > BGP: Fix incorrectly flagged nexthop > > BGP: Save the last message from a peer that caused us to send a > > NOTIFICATION > > > > Dinesh Dutt (17): > > BGP: IPv6 Multipath broken with nexthop global address > > Zebra: Use a fixed route metric when populating kernel > > BGPd: Support matching on local preference in route-map > > bgpd: bgpd-ibgp-policy-out-allow-mods.patch > > BGP: Add match interface support to BGP route-map. > > BGPd: Delete the route from the kernel when a valid NH changes to > > invalid NH > > OSPFv2: Don't wait for state change to Exchange to start LSReq > > VTYSH: Add support for marking a file with appropriate end of context > > Zebra: Suppress displaying default config as part of running config > > Zebra: Add route-map support for Next Hop Tracking > > zebra: allow static routes to use NH's from protocols > > Zebra: Gather and display detailed info about clients of Zebra > > zebra: Honor setting source via route map and pushing that to the > > kernel. > > OSPFv3: Add ABR support and make ECMP > 4. > > BGP: Fix FSM to handle active/passive connections better > > BGP: Reprocess the trigger points when an attached route map changes > > OSPF: Better handle traffic when system is loaded > > > > Donald Sharp (8): > > Quagga: Set MULTIPATH_NUM to 64 when user specifies 0 from cli > > Zebra: Clean up some compile errors that were missed > > vtysh: service integrated-vtysh-config not being written to file > > BGP: Test effect of route-map on received/advertised routes > > OSPF: Add support for Route tags > > BGP: Use next hop tracking for connected routes too > > zebra: Add check to notice when an interface is unnumbered > > ospf6d: ospfv3-stub-area-support.patch > > > > JR Rivers (1): > > OSPF: 16.0 rfc2328 compliance > > > > James Li (3): > > Zebra: Dissallow outside programs to delete Quagga routes > > zebra: Notice passed nexthop is ONLINK > > ospfd: Add unnumbered interface support > > This is still the same unnumbered "hack" we discussed earlier so NACK from > me > > Jocke
_______________________________________________ Quagga-dev mailing list [email protected] https://lists.quagga.net/mailman/listinfo/quagga-dev
