Vivek, On 1/5/2016 8:02 AM, Vivek Venkatraman wrote: > > On Thu, Dec 24, 2015 at 10:10 AM, Lou Berger <[email protected] > <mailto:[email protected]>> wrote: > > This is part of the core VPN and Encap SAFI changes. > > There wasn't much missing for VPNv6 to begin with; just a few bits of > de- & encoding and a few lists to be updated. > > Signed-off-by: Lou Berger <[email protected] <mailto:[email protected]>> > Signed-off-by: David Lamparter <[email protected] > <mailto:[email protected]>> > --- > > diff --git a/bgpd/bgp_packet.c b/bgpd/bgp_packet.c > index a90e56b..35c4719 100644 > --- a/bgpd/bgp_packet.c > +++ b/bgpd/bgp_packet.c > @@ -1885,12 +1885,12 @@ bgp_update_receive (struct peer *peer, > bgp_size_t size) > if (mp_update.length > && mp_update.afi == AFI_IP > && mp_update.safi == SAFI_MPLS_LABELED_VPN) > - bgp_nlri_parse_vpnv4 (peer, NLRI_ATTR_ARG, &mp_update); > + bgp_nlri_parse_vpn (mp_update.afi, peer, &attr, > &mp_update, 0); > > if (mp_withdraw.length > && mp_withdraw.afi == AFI_IP > && mp_withdraw.safi == SAFI_MPLS_LABELED_VPN) > - bgp_nlri_parse_vpnv4 (peer, NULL, &mp_withdraw); > + bgp_nlri_parse_vpn (mp_withdraw.afi, peer, &attr, > &mp_withdraw, 1); > > > Is there a specific reason to pass a 'withdraw flag' rather than pass > the attribute as NULL for withdraw handling? bgp_withdraw() does not > use the 'attr' parameter. > > I'm just trying to understand here. > I think it's a matter of style. While I didn't write the code, I personally prefer being explicit rather than to operate by inference. Paul is still out, but we can ask him -- although I suspect he won't remember.
Lou > > > if (! withdraw_len > && mp_withdraw.afi == AFI_IP > @@ -1904,6 +1904,30 @@ bgp_update_receive (struct peer *peer, > bgp_size_t size) > peer->host); > } > } > _______________________________________________ Quagga-dev mailing list [email protected] https://lists.quagga.net/mailman/listinfo/quagga-dev
