Hello Paul, all

As mention yesterday during the call, I have some problems with new link-params command you introduce and vtysh. Note that it is perfectly running when directly telnet to Zebra process. First, I introduce the new LINK_PARAMS_NODE in vtysh to manage it, including the 'ignore link-params' line in extract.pl file. It works fine except when performing the 'show running' command.

I got this:

interface eth1
  enable
  max-bw 1.25e+07
  max-rsv-bw 6.75e+06
  metric 0
  unrsv-bw 0 1.25e+06
  unrsv-bw 1 1.25e+06
  unrsv-bw 2 1.25e+06
  unrsv-bw 3 1.25e+06
  unrsv-bw 4 1.25e+06
  unrsv-bw 5 1.25e+06
  unrsv-bw 6 1.25e+06
  unrsv-bw 7 1.25e+06
 description "--- Base Interface - To Junix3 (fe-0/0/0) ---"
 ip address 10.194.77.18/30
 ipv6 nd suppress-ra
 link-params
 no link-detect
!

Note that the sub CLI command that normally must fit under the 'link-params' statement are directly print below the 'interface' statement and 'link-param' statement is alone 4 lines after.

Once apply this patch to handle the new LINK_PARAMS_NODE (I just mimic what is done for other sub node)

--- a/vtysh/vtysh_config.c
+++ b/vtysh/vtysh_config.c
@@ -166,7 +166,9 @@ vtysh_config_parse_line (const char *line)
       /* Store line to current configuration. */
       if (config)
        {
-         if (strncmp (line, " address-family vpnv4",
+         if (strncmp (line, " link-params", strlen (" link-params")) == 0)
+           config = config_get (LINK_PARAMS_NODE, line);
+         else if (strncmp (line, " address-family vpnv4",
              strlen (" address-family vpnv4")) == 0)
            config = config_get (BGP_VPNV4_NODE, line);
          else if (strncmp (line, " address-family ipv4 multicast",

I got this:

interface eth1
 ip address 10.194.77.18/30
 ipv6 nd suppress-ra
 no link-detect
!
ip route 10.10.10.10/32 10.194.77.18
!
line vty
!
 link-params
  enable
  metric 0
  max-bw 1.25e+07
  max-rsv-bw 6.75e+06
  unrsv-bw 0 1.25e+06
  unrsv-bw 1 1.25e+06
  unrsv-bw 2 1.25e+06
  unrsv-bw 3 1.25e+06
  unrsv-bw 4 1.25e+06
  unrsv-bw 5 1.25e+06
  unrsv-bw 6 1.25e+06
  unrsv-bw 7 1.25e+06
!
end

Note that this time new link parameters command are under the 'link-params' statement, but this one is put at the end of 'show running' instead below the 'interface' statement.

I try many modification in the code, but don't understand what's wrong and why the 'link-params' statement is not below the 'interface' one.

Can you help me to solve this last issue in order to finalize my TE patches ?

Thanks for your help

Olivier

_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev

Reply via email to