On Fri, 22 Jan 2016, Paul Jakma wrote:
- ospfd went through lots of churn in the GNU Zebra days to add (struct ospf *) everywhere, presumably to try get to multiple-instance. Some of the changes were probably pointless, cause the context was implied in other arguments (e.g. LSAs).
This suggests that this time we should consider another way. It may well be better and faster to add the layer of context by encapsulating the existing code within that context in some way, be it by using processes and/or namespaces and/or containers or whatever - minimising the changes to existing code, and also making it easier to test.
Oh, and to add to a data-point, compare and contrast the churn GNU Zebra took on (struct ospf *)'ification and the success of it (after ~15 years), to how the Cumulus per-process multiple-instance patch and how little code that has to touch and how much easier that was.
regards, -- Paul Jakma [email protected] @pjakma Key ID: 64A2FF6A Fortune: If we see the light at the end of the tunnel, it's the light of an oncoming train. -- Robert Lowell _______________________________________________ Quagga-dev mailing list [email protected] https://lists.quagga.net/mailman/listinfo/quagga-dev
