On 04/06/2016 10:15 AM, Paul Jakma wrote:
> +static void
> +if_zebra_linkdetect_set (struct interface *ifp)
> +{
> + struct zebra_if *zif = ifp->info;
> + assert (zif != NULL);
> + int if_was_operative = if_is_operative(ifp);
> +
> + /* If user has explicitly configured for the interface, let that set */
> + if (zif->linkdetect != IF_LINKDETECT_UNSPEC)
> + if_zebra_linkdetect_set_val (ifp, zif->linkdetect);
> + else
> + {
> + /* general compiled in default is to set */
> + SET_FLAG(ifp->status, ZEBRA_INTERFACE_LINKDETECTION);
> + /* but user can specify a default too */
> + if_zebra_linkdetect_set_val (ifp, zif_defaults.linkdetect);
> + }
> + /* When linkdetection is enabled, if might come down */
> + if (!if_is_operative(ifp) && if_was_operative) if_down(ifp);
You remove the following code that used to be present in the path that
disabled link detect:
> /* Interface may come up after disabling link detection */
> if (if_is_operative(ifp) && !if_was_operative) if_up(ifp);
Shouldn't that be present in the new if_zebra_linkdetect_set?
-Christian
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
