On Mon, 11 Apr 2016, Christian Franke wrote:
Given that the majority of other projects seems to be using kernel style, at least that is what I encounter for almost anything other than Quagga, I would prefer if we could allow for the kernel style to be used in Quagga.
Is it really that difficult to just use whatever the style of a project is?
GNU style was new to me with GNU Zebra, I was more used to Linux kernel style, but it seemed trivial to adapt. And it's fairly to switch style with project contexts - least for me.
I /can/ switch just fine, but I'd like to minimise the switches. I switch between files of the same project a lot more often than I switch between projects. The latter also comes with lots of other context switching overhead.
For me, inconsistency within a code-base is much worse than inconsistencies between projects. And within a project like Quagga, if there are going to be mixes, be nice at least to keep each sub-dir consistent (e.g. I'm more likely to switch between ospfd files, than between ospfd and pimd, say).
So, I'd prefer to minimise the inconsistency in the more common-case switches, and just offload the overhead to other switches (like between projects) that come with lots of other context-to-be-switched overhead anyway.
The argument of consistency could also be made to the point that it would be useful if people could constistently write code in the style which they are accustomed to.
That maybe opens up a can of worms about what people prefer. People do not consistently agree on the best style. People are not even _self_ consistent on the coding style they use (I'm not anyway).
E.g., I now like the 2-space shift. Also, function names in function definitions starting on their own line, at the beginning is useful for grepping (grep ^function shows the definition location). And lots of people will have their own legitimate preferences.
I think there's better things to do than have coding style discussions. GNU or Linux, I don't massively care. I just want to minimise switching overheads. Either will work.
Most of the existing code is GNU style. So just use that cause the notion of trying to move over to Linux style by allowing either is just an argument for a mess of styles, which I find worse than just sticking to something consistent.
I could go with a Go like approach of requiring code to pass through a formatter - make it part of make process or a git hook. Anything but years of a mish-mash of different styles all over the place.
regards, -- Paul Jakma [email protected] @pjakma Key ID: 64A2FF6A Fortune: Isn't it interesting that the same people who laugh at science fiction listen to weather forecasts and economists? -- Kelvin Throop III _______________________________________________ Quagga-dev mailing list [email protected] https://lists.quagga.net/mailman/listinfo/quagga-dev
