11.05.2016, 03:17, "Alexis Rosen" <[email protected]>:
> On Apr 22, 2016, at 11:45 AM, Donald Sharp <[email protected]> wrote:
>>  Paul and I have been discussing this commit:
>>
>>  
>> https://github.com/donaldsharp/quagga/commit/4a77fb6cc78cacfd0c6cd0c35ba766f994a87e11
>>
>>  Quagga behavior without this patch does not take into effect for already 
>> processed events. So if you change a route-map
>>  you need to reset the peer by hand to make it take into effect.
>>
>>  With this code change a timer is started that gets executed after a small 
>> time that causes all routes to be reprocessed.
>>
>>  Paul suggestion is to add an event on 'conf t' exit to immediately expire 
>> the timer if it is still running. Which I am planning on writing here
>>  shortly.
>>
>>  Having said that does anyone else have thoughts on this behavior and what 
>> it may or may not do?
>
> Did anyone answer you? (If so I missed it.)

Nice feature. But in order not to break existing behavior I would prefer
not enabling it by default.

bgpd/bgpd.h:
+#define RMAP_DEFAULT_UPDATE_TIMER 5 /* disabled by default */

This line is weird a little. Either comment is wrong, or
RMAP_DEFAULT_UPDATE_TIMER should be zero.

--
wbr, Oleg.

"Anarchy is about taking complete responsibility for yourself."
      Alan Moore.

_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev

Reply via email to