I've spent a bit of time trying to understand this problem and haven't
gotten anywhere.

I don't remember why I put in:

@@ -622,6 +622,8 @@ install_element (enum node_type ntype, struct
cmd_element *cmd)
   vector_set (cnode->cmd_vector, cmd);
   if (cmd->tokens == NULL)
     cmd->tokens = cmd_parse_format(cmd->string, cmd->doc);
+  else
+    assert(0);

   if (ntype == VIEW_NODE)
     install_element (ENABLE_NODE, cmd);

anymore and I've backed this bit of code out and now I have all commands as
ambiguous when I test.  I'll see what I can find this evening again

donald

On Wed, Jun 15, 2016 at 4:56 AM, Paul Jakma <[email protected]> wrote:

> On Tue, 14 Jun 2016, Donald Sharp wrote:
>
> I would recommend reverting:
>>
>> ceecc7e *: Consolidate all double VIEW_NODE and ENABLE_NODE's
>> 0dbe0d2 lib: Consolidate VIEW_NODE to be ENABLE_NODE as well
>>
>> They are the cause of this breakage.
>>
>> Shall I do this?
>>
>
> No, multiple people working on volatile, rebasing branches leads to stuff
> getting lost, we've discovered!
>
> Also, is there a quick fix? Cause the 2nd especially was high-conflict
> with other patches and the resolution - due to the nature of this - was to
> have to /remove/ stuff to resolve the conflict, including potentially any
> ENABLE_NODE installs added by the other patch.
>
> It may be laborious to revert it, and the idea is good, so a quick fix'd
> be preferable to the revert in this case.
>
> regards,
> --
> Paul Jakma | [email protected] | @pjakma | Key ID: 0xD86BF79464A2FF6A
> Fortune:
> A statesman is a politician who's been dead 10 or 15 years.
>                 -- Harry S. Truman
>
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev

Reply via email to