On Thu, 30 Jun 2016, Martin Winter wrote:
I think so, but would need to go back to my old emails (but I don’t think it’s relevant for the question below)
I thought so.
If so, should we keep the jitter? (It'll just go between 1 and 0 then I think).
I would vote for no. I think that was sensible in the past, but today it gets into the way of everyone wanting fast convergence. And yes, it makes my testing more painful (but that shouldn’t count if there is a real use case/need for it).Curious what everyone else thinks.
Definitely, these connect and connect-retry timers are annoyingly high. Real pain - and there are people giving presentations showing how 'slow' Quagga is, where these timers are a factor in that.
OTOH, cause of collision-detection bugs in old Quagga FSM (least, the fixes are now there, to be integrated), you want to avoid hitting collision detection path in released Quaggas - and jitter in connection timer helps a bit with that. So maybe an idea to keep it for bug-avoidance in remote prior Quagga releases?
Aside: might be value in \{x : 0 < x < 1\} timer values - esp for MRAI timer. Might be worth cooking up as a follow up patch.
regards, -- Paul Jakma | [email protected] | @pjakma | Key ID: 0xD86BF79464A2FF6A Fortune: Say no, then negotiate. -- Helga
_______________________________________________ Quagga-dev mailing list [email protected] https://lists.quagga.net/mailman/listinfo/quagga-dev
