NAK
This fails my package builds.
Here is how I configure the packages for my testing:
--build=x86_64-linux-gnu --prefix=/usr --includedir=${prefix}/include
--mandir=${prefix}/share/man --infodir=${prefix}/share/info
--sysconfdir=/etc --localstatedir=/var
--libexecdir=${prefix}/lib/quagga-test --disable-maintainer-mode
--disable-dependency-tracking
--enable-exampledir=/usr/share/doc/quagga/examples/
--localstatedir=/var/run/quagga --sbindir=/usr/lib/quagga
--sysconfdir=/etc/quagga --enable-vtysh --enable-isisd --enable-pimd
--enable-watchquagga --enable-ospf-te --enable-opaque-lsa --enable-ipv6
--enable-ospfclient=yes --enable-ospfapi=yes --enable-multipath=64
--enable-user=quagga --enable-group=quagga --enable-vty-group=quaggavty
--enable-configfile-mask=0640 --enable-logfile-mask=0640 --enable-rtadv
--enable-gcc-rdynamic --enable-tcp-zebra --enable-fpm
--enable-isis-topology --with-libpam
--with-pkg-extra-version=-ci.NetDEF.org-20160727.222003-git.5f67888
When I install the package and try to run rip afterwards, then I get:
root@ci-comp8-dut:~# ripd -d
privs_init: user((null)) is not part of vty group specified(quaggavty)
We (at OpenSourceRouting) had a similar issue, but the main use when
Quagga was already started under the correct user,
then we just skip the user (and group) changes.
Just an alternative thought. Happy to send the change to the list (or
you) if the community prefers this choice.
- Martin
On 27 Jul 2016, at 15:02, Jafar Al-Gharaibeh wrote:
Leave "user/group" unset when explicitly configuring with
"--disable-user" and "--disable-group". This allows quagga
to skip unsupported system calls such as setuid() on certain
platfroms.
Signed-off-by: Jafar Al-Gharaibeh <ja...@atcorp.com>
---
configure.ac | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index 6206510..b349131 100755
--- a/configure.ac
+++ b/configure.ac
@@ -351,14 +351,16 @@ AC_SUBST(ISIS_TOPOLOGY_LIB)
if test "${enable_user}" = "yes" || test x"${enable_user}" = x"";
then
enable_user="quagga"
+ AC_DEFINE_UNQUOTED(QUAGGA_USER, "${enable_user}", Quagga User)
elif test "${enable_user}" = "no"; then
- enable_user="root"
+ enable_user=""
fi
if test "${enable_group}" = "yes" || test x"${enable_group}" = x"";
then
enable_group="quagga"
+ AC_DEFINE_UNQUOTED(QUAGGA_GROUP, "${enable_group}", Quagga Group)
elif test "${enable_group}" = "no"; then
- enable_group="root"
+ enable_group=""
fi
if test x"${enable_vty_group}" = x"yes" ; then
@@ -371,8 +373,6 @@ fi
AC_SUBST([enable_user])
AC_SUBST([enable_group])
AC_SUBST([enable_vty_group])
-AC_DEFINE_UNQUOTED(QUAGGA_USER, "${enable_user}", Quagga User)
-AC_DEFINE_UNQUOTED(QUAGGA_GROUP, "${enable_group}", Quagga Group)
enable_configfile_mask=${enable_configfile_mask:-0600}
AC_DEFINE_UNQUOTED(CONFIGFILE_MASK, ${enable_configfile_mask}, Mask
for config files)
--
2.7.4
_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev
_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev
