Paul,

On 22 Aug 2016, at 9:27, Paul Jakma wrote:

On Tue, 9 Aug 2016, Martin Winter wrote:

I started at the beginning and cherry-picked commits from proposed 8
into a pull requests and so far got 46 commits of the 159 commits integrated. See https://docs.google.com/spreadsheets/d/16UtC3epcRv6hx5dkRwPOtG3_wRVj5L5guB63g_hmw-s/edit#gid=1711194199 (The green highlighted commits are merged to the dev/automerge branch)

So, this got stuck at 'for (int ...)'? Cause the compiler is in less-than-C99 mode?

Which seems to be due to:

# Build the Debian Source and Binary Package
06-Aug-2016 15:45:33 cd quagga-test; /usr/bin/debuild --preserve-envvar WANT_LDP -us -uc
06-Aug-2016 15:45:34     dpkg-buildpackage -rfakeroot -D -us -uc
06-Aug-2016 15:45:34 dpkg-buildpackage: export CFLAGS from dpkg-buildflags (origin: vendor): -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security 06-Aug-2016 15:45:34 dpkg-buildpackage: export CPPFLAGS from dpkg-buildflags (origin: vendor): -D_FORTIFY_SOURCE=2 06-Aug-2016 15:45:34 dpkg-buildpackage: export CXXFLAGS from dpkg-buildflags (origin: vendor): -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security 06-Aug-2016 15:45:34 dpkg-buildpackage: export FFLAGS from dpkg-buildflags (origin: vendor): -g -O2 06-Aug-2016 15:45:34 dpkg-buildpackage: export LDFLAGS from dpkg-buildflags (origin: vendor): -Wl,-Bsymbolic-functions -Wl,-z,relro

in https://ci1.netdef.org/browse/QUAGGA-GITHUBOSRQUAGGA-CI002BUILD-81/log

Seems to be same issue for a few of them?

E.g., the OBSD fail, it's built fine the first time, but then tries to build it again to build packages but overrides the CFLAGS?

Yes, CFLAGS are overridden for some platforms (to find the needed libraries).

build   06-Aug-2016 15:44:04    # Build package
build 06-Aug-2016 15:44:04 cd myport/net/quagga-test; export PORTSDIR=/home/ci/cibuild.81/myport; make package build 06-Aug-2016 15:44:05 ===> Checking files for quagga-test-20160806.223947p0-git.1f408a5 build 06-Aug-2016 15:44:05 `/home/ci/cibuild.81/myport/distfiles/quagga-source.tar.gz' is up to date.
build   06-Aug-2016 15:44:05    >> (SHA256) quagga-source.tar.gz: OK
build 06-Aug-2016 15:44:05 ===> quagga-test-20160806.223947p0-git.1f408a5 depends on: gawk-* -> gawk-4.1.3 build 06-Aug-2016 15:44:05 ===> quagga-test-20160806.223947p0-git.1f408a5 depends on: gmake-* -> gmake-4.1p0 build 06-Aug-2016 15:44:05 ===> quagga-test-20160806.223947p0-git.1f408a5 depends on: libexecinfo-* -> libexecinfo-0.2p5v0 build 06-Aug-2016 15:44:05 ===> Verifying specs: c curses execinfo m readline termcap build 06-Aug-2016 15:44:05 ===> found c.80.1 curses.14.0 execinfo.2.0 m.9.0 readline.4.0 termcap.14.0 build 06-Aug-2016 15:44:05 ===> Extracting for quagga-test-20160806.223947p0-git.1f408a5 build 06-Aug-2016 15:44:06 ===> Patching for quagga-test-20160806.223947p0-git.1f408a5 build 06-Aug-2016 15:44:06 ===> Configuring for quagga-test-20160806.223947p0-git.1f408a5 build 06-Aug-2016 15:44:06 Using /home/ci/cibuild.81/myport/pobj/quagga-test-20160806.223947-git.1f408a5/config.site (generated) build 06-Aug-2016 15:44:06 cd /home/ci/cibuild.81/myport/pobj/quagga-test-20160806.223947-git.1f408a5/quagga-source && env AUTOMAKE_VERSION=1.15 AUTOCONF_VERSION=2.69 autoreconf -fi <cut, but presumably also settting CFLAGS here?>
...
build 06-Aug-2016 15:44:26 checking whether to set a default CFLAGS... CFLAGS supplied by user

I'll try fix those, but can the testing stuff also be fixed to either not override CFLAGS, or else try remember to set std=c99?

I thought a later commit fixed the c99 issue (Or you changed the loop?). Not sure which commit this would be.
Potentially adding this commit to the set of pull req 17 should fix it.

Just couldn’t find the correct one.

- Martin

_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

Reply via email to