On Thu, 2005-05-19 at 15:55 +0200, Jean Delvare wrote: > Hi all, > > > > If Andreas approves the functionality (which is good, IMHO), finalize > > > would be a much better name. But there's a "if" in my sentence... ;) > > > > "drop" came to my mind first ;)
Drop is fine with me. I'll try to get a patch for it in the next couple days. > Each of these names is (IMHO) meaningful if we choose it for the new > function, but most of them could also mean something different (e.g. > merge could mean "create a single patch from two or more different > patches", somehow an extended version of quilt fold, burrow could mean > "move the given patch at the bottom of the patch stack" etc...) I > realize it's quite hard to find a name which can only mean one thing > and people will get it right at first sight. Oh well, users will have to > read the manual for once ;) Yep, naming can be hard :). > One question comes to my mind about this patch. Most commands work on the > top-most patch by default. Will this one work on the bottom-most patch > by default? It looks like "finalizing" patches (or whatever we call > that) only makes sense if you consider the stack bottom-up. This seems Hm, it works essentially just like the pop command does. It's still top-down. So if you have a set of related patches, say 4, on the stack and you want to "drop" them all then you would do 'quilt drop 4'. Adding the bottom-up approach could be done, and does make some sense. But patches on the stack aren't necessarily related. I.e. you could have 4 patches applied, none of which really have anything to do with the other. So I went with the current design of top-down for now. > to be a somewhat new concept for quilt. Josh, does my remark make sense? > Could you explain to us how you plan to use the new function? More > precisely, what does your stack look like, and what patches from it do > you "finalize"? My specific stack varies quite a bit depending on what I'm doing :). Usually, I have several un-related patches that I'm dealing with. At some point, I want to drop one of them so I can commit it to CVS. This is my most common case. thx, josh _______________________________________________ Quilt-dev mailing list [email protected] http://lists.nongnu.org/mailman/listinfo/quilt-dev
