Hi all,
I noticed that quilt's translation files (po/*.mo) are not built by
"make" but by "make install". This isn't correct. The reason seems to be
that LINGUAS is empty when "make all" is ran in the po subdirectory.
Attached patch fixes it.
I also noticed that the po/*.mo files were deleted twice on "make
clean", once as members of $DIRT and once explicitely. This is harmless
but can be fixed too.
Does it look OK?
As a side note, I would question the fact that "make" (all) and "make
install" recursively call themselves in the po subdirectory, while "make
clean" is handled directly by the top-level Makefile. The Makefile in
the po subdirectory does have a "clean" target, why don't we simply call
it?
Thanks,
--
Jean Delvare
Index: Makefile.in
===================================================================
RCS file: /cvsroot/quilt/quilt/Makefile.in,v
retrieving revision 1.55
diff -u -r1.55 Makefile.in
--- Makefile.in 18 Jun 2005 18:03:57 -0000 1.55
+++ Makefile.in 29 Jun 2005 14:05:16 -0000
@@ -104,7 +104,8 @@
#-----------------------------------------------------------------------
all : scripts
- $(MAKE_NLS) -C po all BUILD_ROOT=$(BUILD_ROOT)
+ $(MAKE_NLS) -C po all BUILD_ROOT=$(BUILD_ROOT) \
+ LINGUAS="$(LINGUAS)" localedir=$(localedir)
scripts : $(BIN:%=bin/%) $(QUILT:%=quilt/%) $(SCRIPTS:%=scripts/%) \
$(LIB:%=lib/%) $(DOC:%=doc/%) $(MAN1)
@@ -261,7 +262,6 @@
clean :
rm -f $(DIRT)
- rm -f po/*.mo
distclean : clean
rm -f config.log config.status Makefile
_______________________________________________
Quilt-dev mailing list
[email protected]
http://lists.nongnu.org/mailman/listinfo/quilt-dev
