Hi Andreas, While reading git log to write quilt's NEWS file I noticed something strange in this commit:
commit 97200435074352529314c9986540bdf92e05f50f Author: Andreas Gruenbacher <[email protected]> Date: Sun Nov 2 16:51:25 2008 +0000 - Add a dual BSD/GPL license header to test/run. - Only run test/patch-wrapper.test if the --with-patch-wrapper config option is used. In the commit I see how you filter out test/patch-wrapper.test by default, which is good. But I don't see where you add it back when --with-patch-wrapper is passed to configure. So in practice patch-wrapper is never tested. I think you intended to add the following change, but forgot? --- quilt.orig/Makefile.in 2014-04-06 22:30:54.519252151 +0200 +++ quilt/Makefile.in 2014-04-06 22:32:23.513161396 +0200 @@ -121,6 +121,9 @@ NON_EXEC_IN := doc/quilt.1 doc/README qu GIT_DESC := $(shell ./git-desc | sed -e 's:^v::') TESTS := $(filter-out test/patch-wrapper.test,$(wildcard test/*.test)) +ifneq ($(PATCH_WRAPPER),) +TESTS += test/patch-wrapper.test +endif DIRT += test/.depend $(wildcard test/.*.ok) # Settings for running the uninstalled version of quilt in the source tree: Thanks, -- Jean Delvare SUSE L3 Support _______________________________________________ Quilt-dev mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/quilt-dev
