Hi Thomas, 2018-06-04 22:16 GMT+02:00 Thomas Gleixner <[email protected]>: > The Message-ID extraction from the cover letter fails because the message > generator uses 'Message-Id' while the extraction uses 'Message-ID'. formail > did not care, but the extraction sed magic cares. As a consequence > threading of the mails is broken. > > Use 'Message-ID' consistently all over the place. > > Fixes: 1d659bebaf3d ("quilt/mail: Remove procmail dependency") > Signed-off-by: Thomas Gleixner <[email protected]> > --- > quilt/mail.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- a/quilt/mail.in > +++ b/quilt/mail.in > @@ -504,7 +504,7 @@ fi > introduction="$(gen_tempfile)" > ( > cat <<-EOF > - Message-Id: <$(msgid)> > + Message-ID: <$(msgid)> > User-Agent: quilt/@VERSION@ > Date: $(date --rfc-822) > From: ${opt_from:-$opt_sender} > @@ -628,7 +628,7 @@ for patch in "${patches[@]}"; do > # Make pipes fail if any of their commands fail (requires bash 3): > set -o pipefail > > - ( ( echo "Message-Id: <$(msgid)>" > + ( ( echo "Message-ID: <$(msgid)>" > awk ' > /^$/ { exit } > tolower($0) !~ /^(message-id|references|in-reply-to):/ \
your patch improves consistency so it's good in any case, but your verson of quilt seems to be missing the following commit: commit 360b85e1f6b6d1aff5ada942fcee816e1ad7a13c Author: Jean Delvare <[email protected]> Date: Fri Apr 14 09:07:51 2017 +0200 mail: Fix patch set threading Let patches reference the introduction message so that the patch set is properly threaded by MUA. This used to work but was broken by accident. This fixes bug #50775: https://savannah.nongnu.org/bugs/index.php?50775 Signed-off-by: Jean Delvare <[email protected]> Fixes: 1d659bebaf3d ("quilt/mail: Remove procmail dependency") Tested-by: Okash Khawaja <[email protected]> Acked-by: Kent R. Spillner <[email protected]> The last release, quilt 0.65, predates this fix. Jean, release? Thanks, Andreas _______________________________________________ Quilt-dev mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/quilt-dev
