Hi Randy,

On Wed, 2025-11-12 at 22:18 -0800, Randy Dunlap wrote:
> "quilt pop -h" says:
> 
> .... Patch
> names may include the patches/ prefix, which means that filename
> completion can be used.
> 
> This doesn't work for me, with or without theĀ  ".patch" suffix.
> It works when "patches/" is omitted and using the filename
> with or without the .patch suffix.
> 
> quilt version: 0.69

This statement in the help text is very old (2004) and rather confusing
in my opinion, because there is nothing special about the completion or
parameter handling of the pop command.

If you do have bash completion installed, the pop command will attempt
to complete on the output of "quilt --quiltrc - applied". These are the
applied patch names without the "patches/" prefix. From your report, I
think you do have the quilt bash completion script installed.

If you don't have bash completion installed, the pop command completion
will naturally fall back to shell paths, so you would need to type
"patches/" first and then you can complete with a patch file name. In
that case, there's no check done on the patch state, so you could
complete with an unapplied patch, which would be invalid.

In both cases, the pop command accepts both raw patch file names, and
patch file names prefixed with "patches/", for convenience. I just
tested and that works for me. Your report suggests it did not work for
you, but I suspect that you got confused by the completion mechanism,
so please double-check.

I think we should drop this statement from the documentation (for both
the pop and the push commands), as it causes more confusion than it
helps, because most users will have bash completion installed while the
statement essentially describes the behavior without it. Instead we
could add a generic statement about how patch file names passed as an
option to any quilt command can optionally be prefixed with "patches/".

-- 
Jean Delvare
SUSE L3 Support

_______________________________________________
Quilt-dev mailing list
[email protected]
https://lists.nongnu.org/mailman/listinfo/quilt-dev

Reply via email to