-> >No, here I am thinking about the cognitive burden. Or something is
-> >there
-> >for a good enough reason, or is has to be removed. There is not point
-> >in a method which returns False at all times.
->
-> I agree.
-> Does *anyone* have anything to say in defense of is_dirty()?
-> I don't.
I think I understand it, but it's something that can pretty easily be
delegated to the Session object directly.
I would propose removing it (deprecating it in the current version) and
putting in a comment suggesting that such functionality be moved into
the commit_changes() function where necessary.
Incidentally, as long as I'm meandering about, I have a question
about this code:
def finish_successful_request(self):
"""Called near the end of each successful request. Not called if
there were any errors processing the request.
"""
session = get_session()
if session is not None:
self.maintain_session(session)
self.commit_changes(session)
Why not put the commit_changes inside the 'if' block? Is there ever a
time that we want to commit changes to None?
(and the same goes for 'abort_changes' call in 'finish_failed_request')
--titus
_______________________________________________
Quixote-users mailing list
[email protected]
http://mail.mems-exchange.org/mailman/listinfo/quixote-users
