Hi Vadim!
I started to make the patch regarding "phLineSetFollowMe" today, and I
have some questions.
I have already a patch with the following items:
1- The "followme" field was added to "phVLine_T" structure;
2- The "vline_free" method deallocates "followme" field;
3- "phLineSetFollowMe" method was added to "phapi-old.c", and two
blocks were enabled again (I've took off the "if 0" condition of both)
on this same file so the "follow me" actually happen;
The problem is that I'm suspicious that the changes on
"ph_answer_request" method will break the logic that made this code
work on prior versions.
Methods "ph_answer_request" and "eXosip_answer_call" used to have a
"contact" parameter that on most of cases will be calculated now by
"owsip_account_contact_get". Unfortunately, on "follow me" scenario, I
think the "contact" will not be available by this method.
Am I right ?
If all my assumptions are right, I'm thinking to add the "contact"
parameter again to both methods ("ph_answer_request" and
"eXosip_answer_call"), and call "owsip_account_contact_get" inside the
last one only when this "contact" parameter is NULL, what will happen
on every condition except the "follow me" scenario.
What you think ?
Thanks and best regards,
Mauro.
Mauro Sergio Ferreira Brasil escreveu:
Wow...
Thanks a lot for the very quick answer Vadim.
I'll send you the patch regarding "phLineSetFollowMe" method as soon as
I get this codes migrated, what I expect won't take too much time.
Thanks again and best regards,
Mauro.
Vadim Lebedev escreveu:
Hi Mauro,
you can use owplMessageSend in place of phLineSendMessage
An'd i'm willing to accetp a patch reinstatit phLineSetFollowMe into
phapi-old.c
Thanks
Vadim
Mauro Sergio Ferreira Brasil wrote:
Hi Vadim!
During my efforts to migrate our codes to "qutecom-2-2-RC3" version, I
found two missing methods that we used on prior versions that are:
"phLineSendMessage" and "phLineSetFollowMe".
- "phLineSendMessage" is present on current codes, but is not being
defined. It's between "if 0" and "endif" statements and with a "// not
used" comment.
- "phLineSetFollowMe", by the other hand, disappeared from current
codes.
Is there any replacement for those methods ?
Thanks and best regards,
Mauro.
Vadim Lebedev escreveu:
Hi
Mauro,
Le 6 mai 09 à 20:09, Mauro Sergio Ferreira Brasil a écrit :
Hello there!
Vadim,
Some time ago, when I was submiting a patch to this list, I told you
that we worked with old versions of the voip libs that we've got from
OpenWengo project and you've asked me why we weren't using the new
version still.
That's it, now we are migrating to new and updated codes
("qutecom-2-2-RC3" version to be more especific) and I would like to
ask some questions to you:
1- Despite of the existence of old methods "phXXX" (phInit,
phAcceptCall, etc) on libraries, I've noticed on entire "sipwrapper"
library (that I suppose is used on QuteCom) the usage of the new
"owplXXX" methods. So, I suppose the use of those new "owplXXX" methods
and associated new callback and constants should be preferable, right ?
Yes...
2- The worst part of
this
migration probably will be to identificate all changes introduced by
prior programmers on original code (which are highlighted) and apply
those that are really necessary. Any of these changes that prove to be
still necessary will be posted as patches to this list. Are you ok with
that ?
Sure...
More than everything I
need
some guidance on question 1.
With this migration done I should get back to the patch regarding
"mode" parameter from "fmtp" attribute negotiation for iLBC codec.
Thanks and best regards,
Thanks a lot for your effort
Vadim
--
| At.,
|
| <CMMI_2.jpg> |
| Technology
and Quality on Information |
| Mauro Sérgio
Ferreira Brasil |
| Coordenador
de Projetos e Analista de Sistemas |
| + [email protected] |
| : www.tqi.com.br |
| ( + 55 (34)3291-1700 |
| ( + 55 (34)9971-2572 |
--
| At.,
|
 |
| Technology
and Quality
on Information |
| Mauro Sérgio
Ferreira Brasil |
| Coordenador
de Projetos e
Analista de Sistemas |
| + [email protected] |
| : www.tqi.com.br |
| ( + 55 (34)3291-1700 |
| ( + 55 (34)9971-2572 |
--
TQI - Technology and Quality on Information
| At.,
|
 |
| Technology
and Quality
on Information |
| Mauro Sérgio
Ferreira Brasil |
| Coordenador
de Projetos e
Analista de Sistemas |
| + [email protected] |
| : www.tqi.com.br |
| ( + 55 (34)3291-1700 |
| ( + 55 (34)9971-2572 |
--
TQI - Technology and Quality on Information
| At.,
|
 |
| Technology and Quality
on Information |
| Mauro Sérgio Ferreira Brasil |
| Coordenador de Projetos e
Analista de Sistemas |
| + [email protected] |
| :
www.tqi.com.br |
| ( + 55
(34)3291-1700 |
| ( + 55
(34)9971-2572 |
|
