Heya,

commit b79b4677f910d101f8f392fb1ec2618ddb4c38da is completely wrong.

The rationale mentioned:
"
- Address the potential problem of chars getting mangled when the URLs
containing UTF8 chars are passed to the application trying to access
the URL
"
would be fixed by saying that quvi always returns valid UTF-8, and the
applications correctly initialising the codeset using:
setlocale (LC_ALL, "");

It breaks the API in a big way, as it mangles RTMP URLs (spaces are now
%20), and might even wrongly escape some characters that didn't need to
be. This is a major API break as URLs returned are now incompatible.

In parallel, I'll point out that the crypto code in libquvi isn't
usable, as there's no calls to gcry_cipher_setiv(), which means it's
impossible to decrypt anything. The cipher mode "GCRY_CIPHER_MODE_CTR"
is also unsupported (needs to call gcry_cipher_setctr()).

Cheers


------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
quvi-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/quvi-devel

Reply via email to