Hi Martin,

On 11-09-23 04:12 PM, Martin Maechler wrote:
Hervé Pagès<hpa...@fhcrc.org>
     on Fri, 23 Sep 2011 11:44:32 -0700 writes:

     >  On 11-09-23 11:02 AM, Sarah Goslee wrote:
     >>  Hi,
     >>
     >>
     >>  2011/9/23 Hervé Pagès<hpa...@fhcrc.org>:
     >>>  Hi,
     >>>
     >>>  With current R devel and R 2.13.1:
     >>>
     >>>>  aa=1:5 save(aa, file="aa.rda", compress="xy")
     >>>  Error in identical(compress, "gzip") || compress :
     >>>  invalid 'y' type in 'x || y'
     >>
     >>  The options for compress are "gzip" "bzip2" or "xz" (and
     >>  not "xy"), at least on my linux system. Are you sure you
     >>  want "xy"?

     >  Right, I wanted "xz", sorry... Maybe error handling could
     >  be improved though so a typo in the input doesn't "break"
     >  the code?

well, what every  ' "break" the code '  means,

"break" here means that the if statement in charge of examining
user input doesn't execute properly for some invalid input.

you are right that a more informative error message makes sense
here (though, the code now is slightly longer).
I've committed such a change {svn rev 57057}.

Thank you!

H.


Martin

     >  Thanks, H.

     >>
     >>  Sarah
     >>
     >>>  Thanks!  H.
     >>>
     >>>>  sessionInfo()
     >>>  R version 2.13.1 (2011-07-08) Platform:
     >>>  x86_64-unknown-linux-gnu (64-bit)
     >>>
     >>>  locale: [1] LC_CTYPE=en_CA.UTF-8 LC_NUMERIC=C [3]
     >>>  LC_TIME=en_CA.UTF-8 LC_COLLATE=en_CA.UTF-8 [5]
     >>>  LC_MONETARY=C LC_MESSAGES=en_CA.UTF-8 [7]
     >>>  LC_PAPER=en_CA.UTF-8 LC_NAME=C [9] LC_ADDRESS=C
     >>>  LC_TELEPHONE=C [11] LC_MEASUREMENT=en_CA.UTF-8
     >>>  LC_IDENTIFICATION=C
     >>>
     >>>  attached base packages: [1] stats graphics grDevices
     >>>  utils datasets methods base
     >>>
     >>>
     >>>  --
     >>





--
Hervé Pagès

Program in Computational Biology
Division of Public Health Sciences
Fred Hutchinson Cancer Research Center
1100 Fairview Ave. N, M1-B514
P.O. Box 19024
Seattle, WA 98109-1024

E-mail: hpa...@fhcrc.org
Phone:  (206) 667-5791
Fax:    (206) 667-1319

______________________________________________
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel

Reply via email to