Thanks for posting this series of patches. Unfortunately, there's a good chance they'll get lost in all the traffic on R-devel. If you don't hear that they've been fixed in the next couple of weeks, could you post them to bugs.r-project.org, and post future patches there as well?

In examples like the one below, if you have R code that shows symptoms, it would really help in the bug report. Otherwise, someone else will have to analyze the code to decide whether it's a bug or missing comment. That takes time, and if there are no known symptoms, it's likely to be assigned a low priority. The sad truth is that very few members of R Core are currently actively fixing bugs.

Duncan Murdoch



On 20/07/2017 5:02 PM, Steve Grubb wrote:
Hello,

There appears to be a break missing in the switch/case for the LISTSXP case.
If this is supposed to fall through, I'd suggest a comment so that others
know its by design.

Signed-off-by: Steve Grubb <sgr...@redhat.com>

Index: src/main/builtin.c
===================================================================
--- src/main/builtin.c  (revision 72935)
+++ src/main/builtin.c  (working copy)
@@ -888,6 +888,7 @@
            SETCAR(t, CAR(x));
            SET_TAG(t, TAG(x));
        }
+       break;
     case VECSXP:
        for (i = 0; i < len; i++)
            if (i < lenx) {

______________________________________________
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel


______________________________________________
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel

Reply via email to