On Tue, Oct 26, 2021 at 1:30 PM Sage Gerard <[email protected]> wrote:
> > Jon: I'm guessing you haven't actually tried this > > Phillip: I guess the check doesn't happen as part of `tz/c`, but I can > tell you that this program > > Yes, but I'm talking about code we were asked to give feedback on. I focus > on `tz/c` because it is documented as a flat contract that checks for "an > identifier from the IANA tz database <https://www.iana.org/time-zones>", > but it does not parse the timezone name to check correctness. > I agree that I would have expected `tz/c` to consult the IANA database. > My feedback says no validation occurs for the timezone name in a parameter > for Splitflap. Joel indicated that parameter will go away below, and I'm > glad to know of the tzinfo package. > Ah, the undocumented `feed-timezone` parameter is not what I had in mind: I've been considering functions like `feed-item` and `episode`, which take their created and updated timestamps as `moment?`s—I think any Racket function that needs to operate on timestamps with timezones ought to operate on `moment?`s (or perhaps `moment-provider?`s). Gregor does ensure that `moment?`s are valid. -Philip -- You received this message because you are subscribed to the Google Groups "Racket Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/racket-users/0100017cbdcf4c28-12d5c1df-f829-4ca2-af95-ec768b5309da-000000%40email.amazonses.com.
