On 01/16/11 21:00, Glyn Kennington wrote:
pancake wrote:
In this case. You just hit one of the missing commands in r2 :) it's in the
TODO. do you mind to implement it and send a patch?
I couldn't see it in any of the TODO files. I'll try implementing the
"r +" in radare first, then take a look at the whole "resize" command
for r2.
good
ired works as intended (syntax "r-#")
In radare2, "r" isn't supported at all. Commented-out code suggests
that it may be handled by a plugin, though I can't see anything relevant
in radare2-extras.
Uhm, which comment?
libr/io/io.c:344
R_API int r_io_resize(struct r_io_t *io, const char *file, int flags, int
mode) {
// XXX not implemented
#if 0
/* TODO */
struct r_io_plugin_t *plugin = r_io_plugin_resolve(file);
...
return -1;
}
nope, what must be implemented in the plugin is the io-specific code
that makes the
truncate operation. But this is (as you can see) not yet implemented.
I'm actually working on a refactoring of the r_io api to fix some design
issues. This
function needs to be implemented as well as in the plugins (add ->resize
method).
Wait for my commit (fixing the r_io_resize) to send the patch adding the
new 'r' command to r2. (io plugins will need to be patched)
I think 'r' must be in core.
Well, the help output doesn't list "r", and anything starting with "r"
at the prompt gives "Invalid command".
yup. it's not implemented :)
In hg tip, src/radare.c:1725. Patch attached.
applied. thanks
_______________________________________________
radare mailing list
[email protected]
http://lists.nopcode.org/listinfo.cgi/radare-nopcode.org
