Chaps,
Rob is correct about the -s trap of the argument parser in falsecolor.pl
This is fixable, and I'd be happy to do this. To my excuse, however, I
must say that the arg parser in any of the csh scripts in Radiance, and
probably in many of the Perl scripts, too, is not terribly
sophisticated. It does its job, but not all possible errors are caught.
The arg parser in Radiance's Perl scripts is free-form, rather than
relying on a module. This is both a deliberate design decision, but also
born out of necessity: The Perl parsers are all based on GNU syntax,
which Radiance doesn't follow. We looked into this, but it turned out
that modifying existing 'bullet proof' modules to deal with all the
quirks of Radiance command line args is simply a pain in the neck.
Existing Perl parsers are good with -s or --short-option style things.
When you throw -a+ vs -a- at them, they just give up. Making this work
properly is a helluva job.
So should -spec be treated as -pal spec (probably not), or should it
throw up a more meaningful error message e.g. 'deprecated'?
Cheers
Axel
> It appears that whenever you enter "-s*" you break the argument
vector parsing. The scale option is expected as:
-s [some number]
or:
-s [a(uto)]
In other words, falsecolor is looking for a "-s", followed by a space, followed by either
an integer (or the letter "a" to indicate autoscaling).
When you enter –spec (or –sun, or –shit, or –supercalifragilisticexpialidocious, for that matter), you
confuse the argument vector parser because it's expecting a space after the –s. So instead of being caught by
the "bad option" case, "-spec" causes an error, and whatever option follows
"–spec" is presented as the culprit, but only because it's the next option in the argument vector.
I agree, it's a misleading error.
In some more other words, I know what the cause is, but not the cure. Axel
(Andy? Greg?), can you help? We need some Perl and Regex assistance here.
- Rob
Rob Guglielmetti
National Renewable Energy Laboratory (NREL)
Commercial Buildings Research Group
15013 Denver West Parkway MS:RSF202
Golden, CO 80401
303.275.4319
[email protected]
On 3/21/13 3:16 PM, "Michael Martinez"
<[email protected]<mailto:[email protected]>> wrote:
Hi Folks,
I installed the latest HEAD yesterday, and learned in a round about way how
-spec has been replaced with -pal spec (or hot or pm3d...)
When I errantly used -spec the error message indicated my mistake was in the -l
or -log options. Reading the new man page showed me the way, but I suppose the
preferred error message would have called my attention to the misuse of -spec
(Also not sure if reporting these small bugs to the dev list is a best
practice, so advanced apologies if this is misplaced...)
Here are the commands I used and the error messages:
$ falsecolor -ip images/6_1_1200.hdr -n 8 -s 8000 -spec -l cd/m2 -log 1 >
test.hdr
bad option "cd/m2"
$ falsecolor -ip images/6_1_1200.hdr -n 8 -s 8000 -spec -log 1 > test.hdr
bad option "1"
$ falsecolor -ip images/6_1_1200.hdr -n 8 -s 8000 -spec > test.hdr
Use of uninitialized value $scale in pattern match (m//) at
/usr/local/bin/falsecolor line 42.
Use of uninitialized value $scale in pattern match (m//) at
/usr/local/bin/falsecolor line 115.
Use of uninitialized value $scale in concatenation (.) or string at
/usr/local/bin/falsecolor line 126.
Use of uninitialized value $value in multiplication (*) at
/usr/local/bin/falsecolor line 273.
Use of uninitialized value $value in multiplication (*) at
/usr/local/bin/falsecolor line 273.
Use of uninitialized value $value in multiplication (*) at
/usr/local/bin/falsecolor line 273.
Use of uninitialized value $value in multiplication (*) at
/usr/local/bin/falsecolor line 273.
Use of uninitialized value $value in multiplication (*) at
/usr/local/bin/falsecolor line 273.
Use of uninitialized value $value in multiplication (*) at
/usr/local/bin/falsecolor line 273.
Use of uninitialized value $value in multiplication (*) at
/usr/local/bin/falsecolor line 273.
Use of uninitialized value $value in multiplication (*) at
/usr/local/bin/falsecolor line 273.
/var/folders/pd/z41h8vkn5ks9d47kx028xvkw0000gn/T/S49kzBYNXL/pc0.cal, line 2:
scale : ;
^ unexpected character
/var/folders/pd/z41h8vkn5ks9d47kx028xvkw0000gn/T/S49kzBYNXL/scol.hdr: bad
picture size
/var/folders/pd/z41h8vkn5ks9d47kx028xvkw0000gn/T/S49kzBYNXL/pc0.cal, line 2:
scale : ;
^ unexpected character
Thanks!
Mike
Michael Martinez ~ Associate
LOISOS + UBBELOHDE
- - - - - - - - - - - - - - - - - - - - - - - - - - -
1917 Clement Avenue Building 10A
Alameda, CA 94501 USA
- - - - - - - - - - - - - - - - - - - - - - - - - - -
510 521 3800 VOICE
510 521 3820 FAX
- - - - - - - - - - - - - - - - - - - - - - - - - - -
www.coolshadow.com<http://www.coolshadow.com/>
_______________________________________________
Radiance-dev mailing list
[email protected]
http://www.radiance-online.org/mailman/listinfo/radiance-dev
_______________________________________________
Radiance-dev mailing list
[email protected]
http://www.radiance-online.org/mailman/listinfo/radiance-dev
