OK. Point taken. I was really just putting my two cents in on a
subject that's important to me personally... ie user variable content
and ACLs.
It would be nice to do something like (I haven't actually looked at
the code, my bad):
page = Page.new
page.headers
page.content = Cache.get_content('/cache/'+cache_file)
page.render
Anyway I'd better have a look at the code myself before I make a/more
of a fool of myself.
Cheers,
On 26/02/2007, at 1:57 PM, Daniel Sheppard wrote:
What I was suggesting wasn't that Page.find_by_url be called on
every page request.... The original email was about changes to the
caching mechanism...
My suggestion, working from your outline:
a) check for the existance of /cache/<url>.yml
b) check for the validity of /cache/<url>.yml
if file exists and is valid:
c) call the page.headers method to set the page headers
d) send /cache/<url>.data
else
e) Call Page.find_by_url to find the page
f) call the page.headers method to set the page headers
g) call the page.render method to render the page content
There's a flaw in your logic - You can't call page.headers until
after you've called Page.find_by_url.
Dan.
_______________________________________________
Radiant mailing list
Post: Radiant@lists.radiantcms.org
Search: http://radiantcms.org/mailing-list/search/
Site: http://lists.radiantcms.org/mailman/listinfo/radiant
_______________________________________________
Radiant mailing list
Post: Radiant@lists.radiantcms.org
Search: http://radiantcms.org/mailing-list/search/
Site: http://lists.radiantcms.org/mailman/listinfo/radiant
