Hello Jerome, thanks for this new patch. It has been rolled in for the next release.
On Tue, 30 Oct 2001 01:32, Jerome Fleury wrote: > --On Monday, October 22, 2001 10:23:24 AM +1000 Mike McCauley > > <[EMAIL PROTECTED]> wrote: > > Hello Jerome, > > > > Thanks for the patch. I think you are right: it is more correct to match > > on the real IP address of the originator, rather than what is claimed in > > NAS-IP-Address. > > > > We have rolled in your patch for the next release. > > Thanks for having inluded it in 2.19. > > I can read this in the changelog: > > Improved duplicate detection in the case (such as Lucent TNT) where > the Nas-IP-Address is not necessarily constant. Patch contributed by > [EMAIL PROTECTED] > > This is not exactly what the patch does, the patch checks for UDP source > port number, because many NAS sometimes send the same Identifiers to the > radius server and the server believes there are duplicates. The IP array is > to be more secure again. (Hope I'm clear enough, sorry for my bad english > :) Another point, this patch is contributed by Benoit Grange > <[EMAIL PROTECTED]> and Jerome Fleury <[EMAIL PROTECTED]> > > Here is another patch, that is pretty useful to us. The purpose is to be > able to insert IP addresses in the SQL database in Integer format. We > handle a lot of accounting tickets in our database (1 million insert/day), > and doing searches based on integer values is DEFINITELY more efficient > than doing them on string values (such as '212.129.4.x'). > It's quite simple to use, we just do something like this in our config > file: AcctColumnDef FRAMEDIPADDRESS,Framed-IP-Address,inet_aton > in an <AuthSQL> statement. > Then we can search through the database using the function INET_ATON('<ip > address>') of mysql (don't know if it exists in other SQL systems) > > This patch should work on 2.18.4 and 2.19 and I hope it will be included in > next release, as it is very simple, but quite useful :) > This patch is contributed by Benoit Grange <[EMAIL PROTECTED]> and > Jerome Fleury <[EMAIL PROTECTED]> > > Thanks for your great support! -- Mike McCauley [EMAIL PROTECTED] Open System Consultants Pty. Ltd Unix, Perl, Motif, C++, WWW 24 Bateman St Hampton, VIC 3188 Australia http://www.open.com.au Phone +61 3 9598-0985 Fax +61 3 9598-0955 Radiator: the most portable, flexible and configurable RADIUS server anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, Platypus, Freeside, TACACS+, PAM, external, Active Directory etc etc on Unix, Win95/8, 2000, NT, MacOS 9, MacOS X === Archive at http://www.open.com.au/archives/radiator/ Announcements on [EMAIL PROTECTED] To unsubscribe, email '[EMAIL PROTECTED]' with 'unsubscribe radiator' in the body of the message.