Fixes #5587. I think it's safer to always use `URI.encode_uri_component` instead of `URI.encode_www_form_component`. Space is going to be encoded as `%20`. Space as `+` sometimes doesn't work. You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5588 -- Commit Summary -- * Use URI.encode_uri_component when generating share urls -- File Changes -- M app/helpers/social_share_button_helper.rb (4) M test/helpers/social_share_button_helper_test.rb (7) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5588.patch https://github.com/openstreetmap/openstreetmap-website/pull/5588.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5588 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/5...@github.com>
_______________________________________________ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
