1ec5 left a comment (openstreetmap/openstreetmap-website#3815)
> A big part of that, I think, comes down to differing review criteria between
> contributors and maintainers. That’s fair to some extent, but it becomes
> frustrating when a maintainer fast-tracks their PR that renders an earlier,
> unreviewed PR obsolete — without any discussion or acknowledgment of the
> overlap. It feels dismissive to those who spent time contributing and
> reviewing.
I haven’t been closely following this repository as long as you, but I didn’t
notice a “queue” pattern that skips what contributors are working on. The
closest thing would be that we were trying to respond to Microsoft’s
contributions while we had their attention.
You have quite a few PRs open, so it must be frustrating to have to juggle them
all, keeping them all up to date with the master branch as it changes. Would
you be interested in self-triaging these PRs, commenting on them to point out
which ones are more fragile (difficult to keep in sync) or which ones need to
be staged first? Or I could take a look and make an educated guess…
> No, but going out of their way to submit a compact PR that is easily
> reviewable (and mergeable - not self-merge though) to undermine a PR, forcing
> their point with a necessary rebase rather than simply having a discussion.
Would you mind elaborating on the situation on your PR or privately, so we can
figure out how to handle it better next time without calling anyone out in this
pinned issue?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3815#issuecomment-3058535926
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/issues/3815/3058535...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
