@hlfan commented on this pull request.
> + $("#export-image").on("turbo:submit-end", async function (event) {
+ if (event.detail.success) {
+ await handleExportSuccess(event.detail.fetchResponse);
+ } else {
+ await handleExportError(event);
+ }
+ });
jquery-simulate is used for forwarding changeset bbox clicks to the
corresponding link, so modifier keys work as expected.
Not sure why it should interfere here.
If I understand correctly the awaits here are more for de-promise-ifying the
already resolved promises than actual awaiting at the time of the submit-end
event, so I'm not expecting a generally noticeable timing difference.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192#discussion_r2229456630
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6192/review/3053094...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
