rkoeze left a comment (openstreetmap/openstreetmap-website#6354)
I am not completely sure. This change was motivated by the fact we support Ruby
3.2+ and so we might reasonably expect a contributor to want to develop against
a different version. That seems like a relatively safe use case to support.
Since we also expect that version to change over time, it also seemed like a
decent candidate for parameterization.
Allowing users to pass entire images, however, feels a bit different. Our
Dockerfile makes certain assumptions that parameterizing the base image will
inevitably break. Depending on the image passed some of the commands in our
Dockerfile may not work. The names of packages may also be different. My
instinct is to avoid having to deal with that.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6354#issuecomment-3228071711
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6354/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
