The avoids using "OK" as a button label, and aligns with the labelling of the cross in the corner of the modal.
I considered alternative labels (like "dismiss") but since we have two ways to close the dialog, the cross is already labelled as "Close", so let's use "Close" for the button too. Before: <img width="893" height="379" alt="Screenshot from 2025-09-24 14-22-16" src="https://github.com/user-attachments/assets/f572dd87-4ec9-4049-9a99-93a96db197c9" /> After: <img width="893" height="379" alt="Screenshot from 2025-09-24 14-24-31" src="https://github.com/user-attachments/assets/d171c568-a631-405a-9e15-2b86b361f9b7" /> You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6418 -- Commit Summary -- * Use Close as the button label to close modal alerts -- File Changes -- M app/views/layouts/_header.html.erb (2) M config/locales/en.yml (1) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/6418.patch https://github.com/openstreetmap/openstreetmap-website/pull/6418.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6418 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/[email protected]>
_______________________________________________ rails-dev mailing list [email protected] https://lists.openstreetmap.org/listinfo/rails-dev
